chore(increment): Handle the use case when increment value is not passed, but payload is

[ecdeveloper]

Right now, if I do something like:

b1.increment({ foo: 'bar' })

This breaks the progress bar.

It'd be nice if we could pass a payload to increment, without explicitly specifying the increment step.

[AndiDittrich]

Hi @ecdeveloper ,

thanks for your contribution. in one of the last releases the update() method has been modified to allow a payload update without affecting the value. just pass null as first argument:

bar.update(null, {
x: "hello"
});

[ecdeveloper]

hey @AndiDittrich ,

In my use case I actually had to increment the progress, along with updating one of the extra values. So technically that would be bar.update(<currentValue> + 1, { x: 'hello' }), which imo is much cleaner to write as bar.increment({ x: 'hello'}).

[AndiDittrich]

imho bar.increment(1, { x: 'hello'}) is also very clean

[ecdeveloper]

@AndiDittrich I wouldn't argue it's clean, but in some cases it may just look ambiguous.

I just happened to notice a similar interface in another library - https://github.com/visionmedia/node-progress#custom-tokens. They let you do both. But I guess it's up to you :)

[AndiDittrich]

i've added the same polymorphic style to update() and increment() - see bd09d07

[ecdeveloper]

@AndiDittrich thanks. Just out of curiosity - why wouldn't you provide feedback so I could tweak this PR, and instead just rewrote this patch in a separate commit?

[AndiDittrich]

it was much faster (only reason)