Skip to content

Commit

Permalink
make .show set display: initial
Browse files Browse the repository at this point in the history
  • Loading branch information
Max Ogden committed Jun 5, 2014
1 parent f37aecb commit c8246a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -2,7 +2,7 @@ var toCamelCase = require("to-camel-case");

module.exports = style;
module.exports.hide = effect('display', 'none');
module.exports.show = effect('display', '');
module.exports.show = effect('display', 'initial');

function all(element, css){
var name;
Expand Down

3 comments on commit c8246a0

@max-mapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azer haha i forgot i was an owner, meant for this to be a pull req. i'm pretty sure it's more correct as I ran into a situation where I had display: none in a stylesheet and doing .show() didn't make it appear since setting display to '' didnt override 'none' (but 'initial' overrides 'none' and makes it show up)

@azer
Copy link

@azer azer commented on c8246a0 Jun 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix :)

@azer
Copy link

@azer azer commented on c8246a0 Jun 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxogden published in npm as 0.0.2 and added you as npm owner to domquery and it's dependencies like this repo and others (key-event dom-tree new-element etc)

Please sign in to comment.