This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix(reify): properly save spec if prerelease #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you add a package w/ spec `*` (or with no spec, which defaults to `*`) arborist tries to do a semver.subset to see if it can use the spec that actually got installed. This fails if the new spec has a prerelease tag in it. This change fixes it so that if the spec was `*` it just goes ahead and uses the new spec no matter what, since no valid semver doesn't match `*` in this case
wraithgar
force-pushed
the
gar/install-prerelease-save
branch
from
05727a4
to
e0bc22d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you add a package w/ spec
*(or with no spec, whichdefaults to
*) arborist tries to do a semver.subset to see if it canuse the spec that actually got installed. This fails if the new spec has
a prerelease tag in it.
This change fixes it so that if the spec was
*it just goes ahead anduses the new spec no matter what, since no valid semver doesn't match
*in this caseThe use case here is when a package tags
latestw/ a version that hasa prerelease tag.
References
Fixes npm/cli#2934