fix(pkg): properly output in workspace mode (#6990)

npm · Nov 13, 2023 · 10db3ca · 10db3ca
1 parent 6ab06d7
commit 10db3ca
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 4 deletions.
diff --git a/lib/commands/pkg.js b/lib/commands/pkg.js
@@ -82,10 +82,9 @@ class Pkg extends BaseCommand {
       }
     }
 
-    // only outputs if not running with workspaces config,
-    // in case you're retrieving info for workspaces the pkgWorkspaces
-    // will handle the output to make sure it get keyed by ws name
-    if (!this.npm.config.get('workspaces')) {
+    // only outputs if not running with workspaces config
+    // execWorkspaces will handle the output otherwise
+    if (!this.workspaces) {
       this.npm.output(JSON.stringify(result, null, 2))
     }
 

diff --git a/test/lib/commands/pkg.js b/test/lib/commands/pkg.js
@@ -618,6 +618,43 @@ t.test('workspaces', async t => {
   )
 })
 
+t.test('single workspace', async t => {
+  const { pkg, OUTPUT } = await mockNpm(t, {
+    prefixDir: {
+      'package.json': JSON.stringify({
+        name: 'root',
+        version: '1.0.0',
+        workspaces: [
+          'packages/*',
+        ],
+      }),
+      packages: {
+        a: {
+          'package.json': JSON.stringify({
+            name: 'a',
+            version: '1.0.0',
+          }),
+        },
+        b: {
+          'package.json': JSON.stringify({
+            name: 'b',
+            version: '1.2.3',
+          }),
+        },
+      },
+    },
+    config: { workspace: ['packages/a'] },
+  })
+
+  await pkg('get', 'name', 'version')
+
+  t.strictSame(
+    JSON.parse(OUTPUT()),
+    { a: { name: 'a', version: '1.0.0' } },
+    'should only return info for one workspace'
+  )
+})
+
 t.test('fix', async t => {
   const { pkg, readPackageJson } = await mockNpm(t, {
     prefixDir: {