Skip to content

Commit

Permalink
feat(libnpmversion)!: remove silent option
Browse files Browse the repository at this point in the history
BREAKING CHANGE: libnpmversion no longer takes a `silent` option to
suppress output from `@npmcli/run-script`. That output is now emitted
via an `output` event on `process`.
  • Loading branch information
lukekarrys committed Apr 16, 2024
1 parent 39e4da0 commit 60faa90
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion workspaces/libnpmversion/README.md
Expand Up @@ -31,7 +31,6 @@ npmVersion(arg, {
ignoreScripts: false, // do not run pre/post/version lifecycle scripts
scriptShell: '/bin/bash', // shell to run lifecycle scripts in
message: 'v%s', // message for tag and commit, replace %s with the version
silent: false, // passed to @npmcli/run-script to control whether it logs
}).then(newVersion => {
console.error('version updated!', newVersion)
})
Expand Down
2 changes: 0 additions & 2 deletions workspaces/libnpmversion/lib/index.js
Expand Up @@ -15,7 +15,6 @@ module.exports = async (newversion, opts = {}) => {
scriptShell = undefined,
preid = null,
message = 'v%s',
silent,
} = opts

const pkg = opts.pkg || await readJson(path + '/package.json')
Expand All @@ -35,6 +34,5 @@ module.exports = async (newversion, opts = {}) => {
preid,
pkg,
message,
silent,
})
}
1 change: 0 additions & 1 deletion workspaces/libnpmversion/lib/version.js
Expand Up @@ -20,7 +20,6 @@ module.exports = async (newversion, opts) => {
ignoreScripts,
preid,
pkg,
silent,
} = opts

const { valid, clean, inc } = semver
Expand Down
2 changes: 0 additions & 2 deletions workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs
Expand Up @@ -24,7 +24,6 @@ Array [
"scriptShell": undefined,
"signGitCommit": false,
"signGitTag": false,
"silent": undefined,
"tagVersionPrefix": "v",
},
]
Expand All @@ -49,7 +48,6 @@ Array [
"scriptShell": "/bin/bash",
"signGitCommit": true,
"signGitTag": true,
"silent": undefined,
"tagVersionPrefix": "=",
},
]
Expand Down

0 comments on commit 60faa90

Please sign in to comment.