fix(exec): ignore packageLockOnly flag

npm · May 3, 2022 · 8ebaea8 · 8ebaea8
1 parent 21b823e
commit 8ebaea8
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 0 deletions.
diff --git a/lib/commands/exec.js b/lib/commands/exec.js
@@ -73,6 +73,9 @@ class Exec extends BaseCommand {
 
     return libexec({
       ...flatOptions,
+      // we explicitly set packageLockOnly to false because if it's true
+      // when we try to install a missing package, we won't actually install it
+      packageLockOnly: false,
       args,
       call,
       localBin,

diff --git a/test/lib/commands/exec.js b/test/lib/commands/exec.js
@@ -385,6 +385,64 @@ t.test('npm exec foo, not present locally or in central loc', async t => {
   ])
 })
 
+t.test('npm exec foo, packageLockOnly set to true', async t => {
+  const path = t.testdir()
+  const installDir = resolve('npx-cache-dir/f7fbba6e0636f890')
+  npm.localPrefix = path
+  npm.config.set('package-lock-only', true)
+  t.teardown(() => {
+    npm.config.set('package-lock-only', false)
+  })
+
+  ARB_ACTUAL_TREE[path] = {
+    inventory: {
+      query () {
+        return new Set()
+      },
+    },
+  }
+  ARB_ACTUAL_TREE[installDir] = {
+    inventory: {
+      query () {
+        return new Set()
+      },
+    },
+  }
+  MANIFESTS.foo = {
+    name: 'foo',
+    version: '1.2.3',
+    bin: {
+      foo: 'foo',
+    },
+    _from: 'foo@',
+  }
+  await exec.exec(['foo', 'one arg', 'two arg'])
+  t.strictSame(MKDIRPS, [installDir], 'need to make install dir')
+  t.match(ARB_CTOR, [{
+    path,
+    packageLockOnly: false,
+  }])
+  t.match(ARB_REIFY, [{
+    add: ['foo@'],
+    legacyPeerDeps: false,
+    packageLockOnly: false,
+  }], 'need to install foo@')
+  t.equal(PROGRESS_ENABLED, true, 'progress re-enabled')
+  const PATH = `${resolve(installDir, 'node_modules', '.bin')}${delimiter}${process.env.PATH}`
+  t.match(RUN_SCRIPTS, [
+    {
+      pkg: { scripts: { npx: 'foo' } },
+      args: ['one arg', 'two arg'],
+      banner: false,
+      path: process.cwd(),
+      stdioString: true,
+      event: 'npx',
+      env: { PATH },
+      stdio: 'inherit',
+    },
+  ])
+})
+
 t.test('npm exec foo, not present locally but in central loc', async t => {
   const path = t.testdir()
   const installDir = resolve('npx-cache-dir/f7fbba6e0636f890')