Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] <Release 6.14.3 contains .pyc compiled Python files> #1037

Closed
targos opened this issue Mar 20, 2020 · 0 comments
Closed

[BUG] <Release 6.14.3 contains .pyc compiled Python files> #1037

targos opened this issue Mar 20, 2020 · 0 comments
Labels
Bug thing that needs fixing Priority Backlog a "backlogged" item that will be tracked in a Project Board semver:patch semver patch level for changes

Comments

@targos
Copy link
Contributor

targos commented Mar 20, 2020

The tarball of npm 6.14.3 contains .pyc compiled Python files in node_modules/node-gyp/gyp/pylib/gyp. Previous versions did not contain these files.

Found while reviewing nodejs/node#32368.
@targos targos mentioned this issue Mar 20, 2020
Closed
@bnoordhuis bnoordhuis mentioned this issue Mar 20, 2020
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Mar 20, 2020
@bnoordhuis
deps: remove *.pyc files from deps/npm
fbecc07 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit to nodejs/node that referenced this issue Mar 23, 2020
@bnoordhuis @BethGriggs
deps: remove *.pyc files from deps/npm
bf26c44 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 24, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
6112ae9 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 24, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
8201704 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ruyadorno ruyadorno added Priority Backlog a "backlogged" item that will be tracked in a Project Board Bug thing that needs fixing semver:patch semver patch level for changes labels Mar 26, 2020
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Apr 1, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
dd4eb8b 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 1, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
f55d071 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

Backport-PR-URL: #32527
PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Priority Backlog a "backlogged" item that will be tracked in a Project Board semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruyadorno @targos