Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Workspaces - bundledDependencies not installed #2207

Open
peterjuras opened this issue Nov 20, 2020 · 1 comment
Open

[BUG] Workspaces - bundledDependencies not installed #2207

peterjuras opened this issue Nov 20, 2020 · 1 comment
Labels
Bug thing that needs fixing Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release

Comments

@peterjuras
Copy link

Current Behavior:

When running npm install to install dependencies in the root of a npm workspace dependencies that are specified in the bundledDependencies property of a child workspace are not installed on the disk.

Expected Behavior:

The dependency should be installed in a local node_modules folder (be it in the root or at the child package level). As far as I understand bundledDependencies should only affect npm when publishing modules so I'm not sure why this is changing npm's behavior when installing dependencies.

Steps To Reproduce:

  1. Clone this sample repository
  2. Ensure you are running npm >= 7
  3. Run npm install in the root of the repository
  4. Run ls node_modules

-> import-from is missing in the node_modules folder, although packages/a declares it as a dependency.

Environment:

OS: macOS 11.0.1
Node: 14.15.1
npm: 7.0.12

@peterjuras peterjuras added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Nov 20, 2020
@darcyclarke darcyclarke added Priority 2 secondary priority issue and removed Needs Triage needs review for next steps labels Jan 29, 2021
@darcyclarke darcyclarke added this to the OSS - Sprint 23 milestone Jan 29, 2021
@jamie-pate
Copy link

see #2207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

3 participants