Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] mtime install issue #3223

Closed
mlucool opened this issue May 10, 2021 · 3 comments · Fixed by npm/pacote#80
Closed

[BUG] mtime install issue #3223

mlucool opened this issue May 10, 2021 · 3 comments · Fixed by npm/pacote#80
Assignees
@isaacs
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release

Comments

@mlucool
Copy link

mlucool commented May 10, 2021

Current Behavior:

Install set the mtime of added files to Oct 26 1985. This originates from here I believe (since moved to here it looks like).

Expected Behavior:

The mtime of the installed files should not be overwritten (I am not suggesting changes to the tarball itself). This is because tools like rsync look at the size + mtime to determine if a file should be copied. If a file has only one character changed, rsync will not copy the file, which leads to some very hard to debug issues! I'll note that yarn does not override the mtime of files.

Steps To Reproduce:

npm i lodash

Environment:

  • OS: Linux
  • Node: v14.16.1
  • npm: 7.11.2
@mlucool mlucool added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels May 10, 2021
@darcyclarke darcyclarke added Needs Review and removed Needs Triage needs review for next steps labels Jun 18, 2021
@darcyclarke
Copy link
Contributor

@isaacs to fix

isaacs added a commit to npm/pacote that referenced this issue Jun 18, 2021
@isaacs
fix: do not set mtime when unpacking
b6b9f6d 
Fixes: npm/cli#3223
isaacs added a commit to npm/pacote that referenced this issue Jun 18, 2021
@isaacs
fix: do not set mtime when unpacking
2ed5b64 
Fixes: npm/cli#3223
@isaacs isaacs mentioned this issue Jun 18, 2021
Merged
@isaacs
Copy link
Contributor

isaacs commented Jun 18, 2021

Will be fixed when npm/pacote#80 lands.

@ssamsundar
Copy link

We are still facing this issue with latest version of npm, whether this issue is fixed for npm publish or pack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaacs isaacs

Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not set mtime when unpacking npm/pacote
4 participants
@isaacs @darcyclarke @mlucool @ssamsundar