Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove npm set-script #5456

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: remove npm set-script #5456

merged 1 commit into from
Sep 8, 2022

Conversation

wraithgar
Copy link
Member

BREAKING CHANGE: this removes npm set-script

Folks should use npm pkg set to set the scripts field in their
package.json

Closes npm/statusboard#449

@wraithgar wraithgar requested a review from a team as a code owner September 1, 2022 14:35
@wraithgar wraithgar changed the title fix: remove npm set-script feat: remove npm set-script Sep 1, 2022
BREAKING CHANGE: this removes `npm set-script`

Folks should use `npm pkg set` to set the `scripts` field in their
`package.json`

Closes npm/statusboard#449
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 1, 2022

found 1 benchmarks with statistically significant performance regressions

  • app-large: no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.205 ±0.27 23.806 ±0.88 21.374 ±0.07 24.883 ±1.41 3.550 ±0.03 3.682 ±0.16 3.015 ±0.00 15.237 ±0.02 2.867 ±0.02 4.032 ±0.05
#5456 47.958 ±0.39 23.741 ±0.15 21.750 ±0.44 24.461 ±0.49 3.562 ±0.04 3.542 ±0.03 2.926 ±0.04 15.210 ±0.29 2.963 ±0.03 4.542 ±0.37
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 32.979 ±2.95 17.454 ±0.16 15.847 ±0.43 16.562 ±0.36 3.349 ±0.03 3.311 ±0.02 2.979 ±0.00 10.629 ±0.05 2.790 ±0.01 3.801 ±0.00
#5456 34.606 ±0.36 17.833 ±0.14 15.783 ±0.02 17.098 ±0.92 3.302 ±0.03 3.315 ±0.03 3.081 ±0.10 10.759 ±0.06 2.777 ±0.04 3.752 ±0.05

@TheJaredWilcurt
Copy link

For those looking up what happened, change your code from this:

npm set-script start "nw ."

to this

npm pkg set scripts.start="nw ."

As the author of the original RFC for set-script, I'm fully in favor of this more versatile approach.

@lukekarrys
Copy link
Contributor

Thank you @TheJaredWilcurt! I'm going to copy your comment to the #5844 issue for more visibility for others needing to migrate from v8 to v9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE(set-script): Remove command
5 participants