Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove npm set-script #5456

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: remove npm set-script #5456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
96 changes: 0 additions & 96 deletions lib/commands/set-script.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/utils/cmd-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ const cmdList = [
'run-script',
'search',
'set',
'set-script',
'shrinkwrap',
'star',
'stars',
Expand Down
38 changes: 19 additions & 19 deletions smoke-tests/tap-snapshots/test/index.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ All commands:
hook, init, install, install-ci-test, install-test, link,
ll, login, logout, ls, org, outdated, owner, pack, ping,
pkg, prefix, profile, prune, publish, query, rebuild, repo,
restart, root, run-script, search, set, set-script,
shrinkwrap, star, stars, start, stop, team, test, token,
uninstall, unpublish, unstar, update, version, view, whoami
restart, root, run-script, search, set, shrinkwrap, star,
stars, start, stop, team, test, token, uninstall, unpublish,
unstar, update, version, view, whoami

Specify configs in the ini-formatted file:
{CWD}/smoke-tests/test/tap-testdir-index/.npmrc
Expand Down Expand Up @@ -597,21 +597,7 @@ exports[`test/index.js TAP npm pkg > should print package.json contents 1`] = `

`

exports[`test/index.js TAP npm prefix > should have expected prefix output 1`] = `
{CWD}/smoke-tests/test/tap-testdir-index/project

`

exports[`test/index.js TAP npm run-script > should have expected run-script output 1`] = `

> project@1.0.0 hello
> echo Hello

Hello

`

exports[`test/index.js TAP npm set-script > should have expected script added package.json result 1`] = `
exports[`test/index.js TAP npm pkg set scripts > should have expected script added package.json result 1`] = `
{
"name": "project",
"version": "1.0.0",
Expand All @@ -634,7 +620,21 @@ exports[`test/index.js TAP npm set-script > should have expected script added pa

`

exports[`test/index.js TAP npm set-script > should have expected set-script output 1`] = `
exports[`test/index.js TAP npm pkg set scripts > should have expected set-script output 1`] = `

`

exports[`test/index.js TAP npm prefix > should have expected prefix output 1`] = `
{CWD}/smoke-tests/test/tap-testdir-index/project

`

exports[`test/index.js TAP npm run-script > should have expected run-script output 1`] = `

> project@1.0.0 hello
> echo Hello

Hello

`

Expand Down
4 changes: 2 additions & 2 deletions smoke-tests/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ t.test('npm outdated', async t => {
t.matchSnapshot(err.stdout, 'should have expected outdated output')
})

t.test('npm set-script', async t => {
const cmdRes = await exec('set-script', 'hello', 'echo Hello')
t.test('npm pkg set scripts', async t => {
const cmdRes = await exec('pkg', 'set', 'scripts.hello=echo Hello')

t.matchSnapshot(cmdRes, 'should have expected set-script output')
t.matchSnapshot(
Expand Down
1 change: 0 additions & 1 deletion tap-snapshots/test/lib/commands/completion.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ Array [
run-script
search
set
set-script
shrinkwrap
star
stars
Expand Down
13 changes: 0 additions & 13 deletions tap-snapshots/test/lib/load-all-commands.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,19 +802,6 @@ npm set <key>=<value> [<key>=<value> ...] (See \`npm config\`)
Run "npm help set" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command set-script > must match snapshot 1`] = `
Set tasks in the scripts section of package.json, deprecated

Usage:
npm set-script [<script>] [<command>]

Options:
[-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
[-ws|--workspaces] [--include-workspace-root]

Run "npm help set-script" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command shrinkwrap > must match snapshot 1`] = `
Lock down dependency versions for publication

Expand Down
35 changes: 12 additions & 23 deletions tap-snapshots/test/lib/npm.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ All commands:
hook, init, install, install-ci-test, install-test, link,
ll, login, logout, ls, org, outdated, owner, pack, ping,
pkg, prefix, profile, prune, publish, query, rebuild, repo,
restart, root, run-script, search, set, set-script,
shrinkwrap, star, stars, start, stop, team, test, token,
uninstall, unpublish, unstar, update, version, view, whoami
restart, root, run-script, search, set, shrinkwrap, star,
stars, start, stop, team, test, token, uninstall, unpublish,
unstar, update, version, view, whoami

Specify configs in the ini-formatted file:
/some/config/file/.npmrc
Expand Down Expand Up @@ -63,9 +63,9 @@ All commands:
hook, init, install, install-ci-test, install-test, link,
ll, login, logout, ls, org, outdated, owner, pack, ping,
pkg, prefix, profile, prune, publish, query, rebuild, repo,
restart, root, run-script, search, set, set-script,
shrinkwrap, star, stars, start, stop, team, test, token,
uninstall, unpublish, unstar, update, version, view, whoami
restart, root, run-script, search, set, shrinkwrap, star,
stars, start, stop, team, test, token, uninstall, unpublish,
unstar, update, version, view, whoami

Specify configs in the ini-formatted file:
/some/config/file/.npmrc
Expand Down Expand Up @@ -99,9 +99,9 @@ All commands:
hook, init, install, install-ci-test, install-test, link,
ll, login, logout, ls, org, outdated, owner, pack, ping,
pkg, prefix, profile, prune, publish, query, rebuild, repo,
restart, root, run-script, search, set, set-script,
shrinkwrap, star, stars, start, stop, team, test, token,
uninstall, unpublish, unstar, update, version, view, whoami
restart, root, run-script, search, set, shrinkwrap, star,
stars, start, stop, team, test, token, uninstall, unpublish,
unstar, update, version, view, whoami

Specify configs in the ini-formatted file:
/some/config/file/.npmrc
Expand Down Expand Up @@ -135,9 +135,9 @@ All commands:
hook, init, install, install-ci-test, install-test, link,
ll, login, logout, ls, org, outdated, owner, pack, ping,
pkg, prefix, profile, prune, publish, query, rebuild, repo,
restart, root, run-script, search, set, set-script,
shrinkwrap, star, stars, start, stop, team, test, token,
uninstall, unpublish, unstar, update, version, view, whoami
restart, root, run-script, search, set, shrinkwrap, star,
stars, start, stop, team, test, token, uninstall, unpublish,
unstar, update, version, view, whoami

Specify configs in the ini-formatted file:
/some/config/file/.npmrc
Expand Down Expand Up @@ -839,17 +839,6 @@ All commands:

Run "npm help set" for more info

set-script Set tasks in the scripts section of package.json, deprecated

Usage:
npm set-script [<script>] [<command>]

Options:
[-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
[-ws|--workspaces] [--include-workspace-root]

Run "npm help set-script" for more info

shrinkwrap Lock down dependency versions for publication

Usage:
Expand Down
8 changes: 0 additions & 8 deletions tap-snapshots/test/lib/utils/cmd-list.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,6 @@ Object {
"searc": "search",
"search": "search",
"set": "set",
"set-": "set-script",
"set-s": "set-script",
"set-sc": "set-script",
"set-scr": "set-script",
"set-scri": "set-script",
"set-scrip": "set-script",
"set-script": "set-script",
"sho": "show",
"show": "show",
"shr": "shrinkwrap",
Expand Down Expand Up @@ -466,7 +459,6 @@ Object {
"run-script",
"search",
"set",
"set-script",
"shrinkwrap",
"star",
"stars",
Expand Down