-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winterqt/libnpmpack foreground scripts #5645
Conversation
wraithgar
commented
Oct 5, 2022
- fix(libnpmpack): obey foregroundScripts
- chore: add spawk as a dev dependency
c80ed82
to
559b6a7
Compare
559b6a7
to
a12bb39
Compare
Doesn't initializing spawk in the test like that cause |
Nope, |
Oh, well I see what you mean here https://github.com/npm/promise-spawn/blob/main/lib/index.js#L1 The |
Oh I mixed TLDR when using |
Ah, right, you loaded it before everything else but only initialized it further in the tests. Was the change from |
The rmdir error was because of |