Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow new majors of node to be automatically considered supported #697

Closed
wants to merge 1 commit into from

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Jan 16, 2020

What / Why

New major versions of node shouldn't be reported as "too old" or unsupported, in the absence of an explicit "known broken" declaration.

Per #696 (comment)

@ljharb ljharb requested a review from a team as a code owner January 16, 2020 19:41
@ljharb ljharb mentioned this pull request Jan 16, 2020
@ljharb
Copy link
Contributor Author

ljharb commented Jan 16, 2020

I have no idea where the tests for this might be; happy to write some if I can be pointed in the right direction.

@mikemimik mikemimik added Community Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature labels Jan 29, 2020
@darcyclarke darcyclarke removed the Release 7.x work is associated with a specific npm 7 release label Feb 18, 2020
@darcyclarke
Copy link
Contributor

@ljharb This looks good although we may want to make a few changes. This will potentially land although we'll update the implementation a bit. Thanks!

@darcyclarke darcyclarke added this to the OSS - Sprint 4 milestone Feb 18, 2020
@darcyclarke darcyclarke self-requested a review February 18, 2020 17:34
@darcyclarke darcyclarke self-assigned this Feb 18, 2020
@ljharb
Copy link
Contributor Author

ljharb commented Feb 18, 2020

@darcyclarke great! i'm happy to make the changes as well if comments are posted; either way's fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants