Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out tar version when the flag is supported #154

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Print out tar version when the flag is supported #154

merged 1 commit into from
Feb 18, 2019

Conversation

agudulin
Copy link
Contributor

@agudulin agudulin commented Feb 8, 2019

What

Not all the tar implementations support --version flag.

E.g. the one used in openbsd doesn't, so the installation process fails trying to print out tar version.

@agudulin
print out tar version when the flag is supported
de7c381 
not all the tar implementations support --version flag
e.g. the one used in openbsd doesn't, so the installation process fails
@agudulin agudulin requested a review from a team as a code owner February 8, 2019 16:36
zkat
zkat approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It'll take a while for us to deploy this to our infra (once it's merged), but the patch is appreciated. Thank you!

@zkat zkat added the semver:patch semver patch level for changes label Feb 11, 2019
@zkat zkat changed the base branch from latest to release-next February 18, 2019 22:24
@zkat zkat merged commit 1a0dd20 into npm:release-next Feb 18, 2019
zkat pushed a commit that referenced this pull request Feb 18, 2019
@agudulin @zkat
install.sh: print out tar version when the flag is supported (#154)
774fc26 
not all the tar implementations support --version flag
e.g. the one used in openbsd doesn't, so the installation process fails

PR-URL: #154
Credit: @agudulin
Reviewed-By: @zkat
This was referenced Feb 1, 2020
Open
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 15, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 1, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Apr 30, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agudulin @zkat