add whoami and get-identity tests

lib/utils/get-identity.js

@@ -4,10 +4,10 @@ const npm = require('../npm')
 const needsAuthError = (msg) =>
   Object.assign(new Error(msg), { code: 'ENEEDAUTH' })
 
-module.exports = async (opts = {}, spec = null) => {
+module.exports = async (opts = {}) => {
   const { registry } = opts
   if (!registry) {
-    throw new Error('no default registry set')
+    throw Object.assign(new Error('No registry specified.'), { code: 'ENOREGISTRY' })
   }
 
   // First, check if we have a user/pass-based auth
@@ -20,8 +20,7 @@ module.exports = async (opts = {}, spec = null) => {
   } else if (token) {
     // No username, but we have a token; fetch the username from registry
     const registryData = await npmFetch.json('/-/whoami', {
-      ...opts,
-      spec
+      ...opts
     })
     const { username: usernameFromRegistry } = registryData
     // Retrieved username from registry; return it

test/lib/utils/get-identity.js

@@ -0,0 +1,107 @@
+const { test } = require('tap')
+const requireInject = require('require-inject')
+
+test('throws ENOREGISTRY when no registry option is provided', async (t) => {
+  t.plan(2)
+  const getIdentity = requireInject('../../../lib/utils/get-identity.js', {
+    '../../../lib/npm.js': {}
+  })
+
+  try {
+    await getIdentity()
+  } catch (err) {
+    t.equal(err.code, 'ENOREGISTRY', 'assigns the appropriate error code')
+    t.equal(err.message, 'No registry specified.', 'returns the correct error message')
+  }
+})
+
+test('returns username from uri when provided', async (t) => {
+  t.plan(1)
+
+  const getIdentity = requireInject('../../../lib/utils/get-identity.js', {
+    '../../../lib/npm.js': {
+      config: {
+        getCredentialsByURI: () => {
+          return { username: 'foo' }
+        }
+      }
+    }
+  })
+
+  const identity = await getIdentity({ registry: 'https://registry.npmjs.org' })
+  t.equal(identity, 'foo', 'returns username from uri')
+})
+
+test('calls registry whoami when token is provided', async (t) => {
+  t.plan(3)
+
+  const options = {
+    registry: 'https://registry.npmjs.org',
+    token: 'thisisnotreallyatoken'
+  }
+
+  const getIdentity = requireInject('../../../lib/utils/get-identity.js', {
+    '../../../lib/npm.js': {
+      config: {
+        getCredentialsByURI: () => options
+      }
+    },
+    'npm-registry-fetch': {
+      json: (path, opts) => {
+        t.equal(path, '/-/whoami', 'calls whoami')
+        t.same(opts, options, 'passes through provided options')
+        return { username: 'foo' }
+      }
+    }
+  })
+
+  const identity = await getIdentity(options)
+  t.equal(identity, 'foo', 'fetched username from registry')
+})
+
+test('throws ENEEDAUTH when response does not include a username', async (t) => {
+  t.plan(3)
+
+  const options = {
+    registry: 'https://registry.npmjs.org',
+    token: 'thisisnotreallyatoken'
+  }
+
+  const getIdentity = requireInject('../../../lib/utils/get-identity.js', {
+    '../../../lib/npm.js': {
+      config: {
+        getCredentialsByURI: () => options
+      }
+    },
+    'npm-registry-fetch': {
+      json: (path, opts) => {
+        t.equal(path, '/-/whoami', 'calls whoami')
+        t.same(opts, options, 'passes through provided options')
+        return {}
+      }
+    }
+  })
+
+  try {
+    await getIdentity(options)
+  } catch (err) {
+    t.equal(err.code, 'ENEEDAUTH', 'throws correct error code')
+  }
+})
+
+test('throws ENEEDAUTH when neither username nor token is configured', async (t) => {
+  t.plan(1)
+  const getIdentity = requireInject('../../../lib/utils/get-identity.js', {
+    '../../../lib/npm.js': {
+      config: {
+        getCredentialsByURI: () => ({})
+      }
+    }
+  })
+
+  try {
+    await getIdentity({ registry: 'https://registry.npmjs.org' })
+  } catch (err) {
+    t.equal(err.code, 'ENEEDAUTH', 'throws correct error code')
+  }
+})

test/lib/whoami.js

@@ -0,0 +1,34 @@
+const { test } = require('tap')
+const requireInject = require('require-inject')
+
+test('whoami', (t) => {
+  t.plan(3)
+  const whoami = requireInject('../../lib/whoami.js', {
+    '../../lib/utils/get-identity.js': () => Promise.resolve('foo'),
+    '../../lib/npm.js': { flatOptions: {} },
+    '../../lib/utils/output.js': (output) => {
+      t.equal(output, 'foo', 'should output the username')
+    }
+  })
+
+  whoami([], (err) => {
+    t.ifError(err, 'npm whoami')
+    t.ok('should successfully print username')
+  })
+})
+
+test('whoami json', (t) => {
+  t.plan(3)
+  const whoami = requireInject('../../lib/whoami.js', {
+    '../../lib/utils/get-identity.js': () => Promise.resolve('foo'),
+    '../../lib/npm.js': { flatOptions: { json: true } },
+    '../../lib/utils/output.js': (output) => {
+      t.equal(output, '"foo"', 'should output the username as json')
+    }
+  })
+
+  whoami([], (err) => {
+    t.ifError(err, 'npm whoami')
+    t.ok('should successfully print username as json')
+  })
+})