Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass publishConfig through to npm-registry-fetch #1949

Closed
wants to merge 2 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Oct 12, 2020

This makes sure that publishConfig is passed through to npm-registry-fetch for both publish and unpublish commands, as well as updates npm-registry-fetch to a version that actually cares about that setting.

Closes #1937

@nlf nlf requested a review from a team as a code owner October 12, 2020 17:34
@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Oct 12, 2020
darcyclarke pushed a commit that referenced this pull request Oct 12, 2020
PR-URL: https://github.com/Usage:
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url>
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin]
(will read url/id from clipboard if not specified)
Credit: @
Close: #1949
Reviewed-by: @darcyclarke
darcyclarke pushed a commit that referenced this pull request Oct 12, 2020
PR-URL: https://github.com/Usage:
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url>
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin]
(will read url/id from clipboard if not specified)
Credit: @ruyadorno
Close: #1949
Reviewed-by: @darcyclarke
darcyclarke pushed a commit that referenced this pull request Oct 12, 2020
PR-URL: https://github.com/Usage:
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url>
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin]
(will read url/id from clipboard if not specified)
Credit: @nlf
Close: #1949
Reviewed-by: @darcyclarke
@isaacs isaacs closed this in c474a15 Oct 13, 2020
@nlf nlf deleted the nlf/pass-publishConfig branch March 28, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants