Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined error caused by npm outdated -g #197

Closed
wants to merge 1 commit into from

Conversation

firedfox
Copy link

Following error is shown when npm outdated -g is called:

npm ERR! Cannot read property 'length' of undefined

This patch fixes the problem by setting path to an empty string when tree.package.name is undefined.

@firedfox firedfox requested a review from a team as a code owner May 20, 2019 07:38
@Teamop
Copy link

Teamop commented May 31, 2019

Already fixed in #173

@Zearin
Copy link
Contributor

Zearin commented Jun 1, 2019

It’s been fixed in #173 for ages. Since 2019-03-20, in fact.

So, why is it taking so long to publish this bugfix?

@firedfox
Copy link
Author

Here’s an update on what’s been happening with the open PRs https://gist.github.com/aeschright/8ed09cbc2a4aee00fcb4ad35086d76a6
I'll close this PR and just wait

@firedfox firedfox closed this Jun 14, 2019
@ljharb
Copy link
Collaborator

ljharb commented Jun 14, 2019

No point in closing the PR; waiting would be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants