Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-install script name #2024

Closed

Conversation

irajtaghlidi
Copy link
Contributor

fix a typo in documentations : using-npm -> scripts.

correct the 'postinstall' script file.

@irajtaghlidi irajtaghlidi requested a review from a team as a code owner October 23, 2020 11:40
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Oct 23, 2020
@isaacs isaacs closed this in aeb10d2 Oct 23, 2020
KevinFCormier added a commit to KevinFCormier/npm-cli that referenced this pull request May 21, 2021
I think this change was incorrect: npm#2024

The point of this example is that the same script is being used for two different stages (`install` and `post-install`) so it would be a good idea to look at the `npm_lifecycle_event` environment variable inside this script to determine which stage is being run.
wraithgar pushed a commit to KevinFCormier/npm-cli that referenced this pull request May 24, 2021
I think this change was incorrect: npm#2024

The point of this example is that the same script is being used for two different stages (`install` and `post-install`) so it would be a good idea to look at the `npm_lifecycle_event` environment variable inside this script to determine which stage is being run.

PR-URL: npm#3282
Credit: @KevinFCormier
Close: npm#3282
Reviewed-by: @wraithgar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants