Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sh as default unix shell, not bash #2067

Closed
wants to merge 1 commit into from
Closed

use sh as default unix shell, not bash #2067

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Oct 28, 2020

References

@isaacs isaacs requested a review from a team as a code owner October 28, 2020 17:50
nlf
nlf approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

this matches the default in @npmcli/run-script and is more appropriate than bash

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Oct 28, 2020
@ruyadorno ruyadorno mentioned this pull request Oct 30, 2020
Merged
@ruyadorno ruyadorno closed this in 3990b42 Oct 30, 2020
@lpinca lpinca mentioned this pull request Nov 1, 2020
Closed
2 tasks
@SimenB SimenB mentioned this pull request Nov 5, 2020
Closed
@nlf nlf deleted the isaacs/bash-to-sh branch March 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaacs @nlf @darcyclarke