Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm exec on folders missing package.json #2081

Closed
wants to merge 1 commit into from
Closed

fix: npm exec on folders missing package.json #2081

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Collaborator

@ruyadorno ruyadorno commented Oct 29, 2020 •
edited

This fixes running npm exec in folders that does not have a package.json file.

Fixes: #1975
Fixes: #2078

@ruyadorno
fix: npm exec on folders missing package.json
be6859e 
This fixes running `npm exec` in folders that does not have a
`package.json` file.

Fixes: npm#1975
@ruyadorno ruyadorno requested a review from a team as a code owner October 29, 2020 16:39
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Oct 29, 2020
@ruyadorno ruyadorno self-assigned this Oct 29, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 18 milestone Oct 29, 2020
@ruyadorno ruyadorno mentioned this pull request Oct 29, 2020
Closed
@ljharb ljharb mentioned this pull request Oct 30, 2020
Closed
nlf
nlf approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ruyadorno ruyadorno closed this in 81d6cee Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 18
Development

Successfully merging this pull request may close these issues.

[BUG] npm -C ./dir exec cmd fails [BUG] NPX does not work outside package directories
2 participants
@ruyadorno @nlf