Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): skip coverage for results.sort #2523

Merged
merged 1 commit into from Jan 28, 2021
Merged

chore(tests): skip coverage for results.sort #2523

merged 1 commit into from Jan 28, 2021

Conversation

wraithgar
Copy link
Member

We finally know why this is happening, and it's because
the array that it is sorting isn't deterministic. Explanation
is in the comments above the function, line is ignored, no
more random CI test failures.

@wraithgar wraithgar requested a review from a team as a code owner January 21, 2021 17:12
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Jan 21, 2021
@npm-deploy-user
Copy link

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
legacy-peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 39.217 ±0.22 23.331 ±0.44 25.038 ±0.57 23.411 ±0.80 1.753 ±0.06 1.758 ±0.02 1.226 ±0.03 9.231 ±0.05 1.245 ±0.02 3.135 ±0.29
#2523 37.386 ±2.02 23.151 ±0.06 22.652 ±0.85 21.097 ±0.69 1.810 ±0.02 1.751 ±0.01 1.238 ±0.01 9.188 ±0.02 1.229 ±0.01 2.987 ±0.02
app-medium clean lock-only cache-only cache-only
legacy-peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 26.936 ±0.73 16.001 ±0.02 17.167 ±0.03 16.271 ±0.23 1.657 ±0.00 1.639 ±0.03 1.168 ±0.03 5.727 ±0.04 1.175 ±0.04 2.586 ±0.34
#2523 25.922 ±0.61 16.240 ±0.05 16.206 ±1.77 15.098 ±0.26 1.675 ±0.05 1.647 ±0.04 1.158 ±0.02 5.716 ±0.05 1.160 ±0.02 2.360 ±0.05

@darcyclarke darcyclarke added the semver:patch semver patch level for changes label Jan 26, 2021
@wraithgar @nlf
chore(tests): skip coverage for results.sort
ba3aa4c 
We finally know why this is happening, and it's because
the array that it is sorting isn't deterministic. Explanation
is in the comments above the function, line is ignored, no
more random CI test failures.

PR-URL: #2523
Credit: @wraithgar
Close: #2523
Reviewed-by: @darcyclarke
@nlf nlf changed the base branch from latest to release/v7.5.0 January 28, 2021 20:35
@nlf nlf merged commit ba3aa4c into release/v7.5.0 Jan 28, 2021
@wraithgar wraithgar deleted the gar/test-help-coverage branch November 2, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke darcyclarke approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wraithgar @npm-deploy-user @darcyclarke @nlf