Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node gyp 5.0.4 #260

Closed
wants to merge 1 commit into from
Closed

node gyp 5.0.4 #260

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Sep 29, 2019

Good to get on the list for 6.12, if possible. Let's see what CI says.

@isaacs isaacs requested a review from a team as a code owner September 29, 2019 07:05
@isaacs isaacs changed the base branch from latest to release-6.12.0 September 29, 2019 07:06
@cclauss cclauss mentioned this pull request Sep 29, 2019
Closed
63 tasks
cclauss
cclauss approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

This was referenced Sep 29, 2019
Closed
Closed
isaacs added a commit that referenced this pull request Sep 30, 2019
@isaacs
node-gyp@5.0.4
bee6d42 
PR-URL: #260
Credit: @isaacs
Close: #260
Reviewed-by: @isaacs
@cclauss cclauss mentioned this pull request Oct 2, 2019
Closed
@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2019

v5.0.5 and v6.0.0 have also now been released...
nodejs/node-gyp#1905 (comment)

@isaacs
Copy link
Contributor Author

isaacs commented Oct 7, 2019

Landed 5.0.5 in the 6.12 release branch. Closing this.

@isaacs isaacs closed this Oct 7, 2019
@sam-github sam-github mentioned this pull request Oct 8, 2019
Closed
@nlf nlf deleted the node-gyp-5.0.4 branch March 28, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@mikemimik mikemimik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaacs @cclauss @mikemimik