increase test coverage some more #2601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
Release 7.x
ruyadorno
approved these changes
Feb 4, 2021
wraithgar
approved these changes
Feb 4, 2021
PR-URL: #2601 Credit: @nlf Close: #2601 Reviewed-by: @ruyadorno, @wraithgar
ruyadorno
force-pushed
the
nlf/remove-spawn-util
branch
from
b7e516a
to
eafb0aa
Compare
ruyadorno
pushed a commit
that referenced
this pull request
Feb 5, 2021
- remove spawn util, refactor help command - add tests for read-user-info, minor refactor - add tests for pulse-till-done util, refactor - add tests for otplease util - add tests for open-url util - remove unused no-progress-while-running util PR-URL: #2601 Credit: @nlf Close: #2601 Reviewed-by: @ruyadorno, @wraithgar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes
lib/utils/spawn.jsin favor of in-liningchild_process.spawninlib/help.jsremoves the unused
lib/utils/no-progress-while-running.jsrefactors and adds tests for
lib/utils/read-user-info.jsrefactors and adds tests for
lib/utils/pulse-till-done.js(also removed callback-y function since it's unused)adds tests for
lib/utils/otplease.jsadds tests for
lib/utils/open-url.jsReferences