Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore the prefix on output from npm version <inc> #2718

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Feb 17, 2021

we used to do this in npm 6, and stopped in npm 7 unintentionally. this restores that behavior in a slightly more intelligent way.

by default the --tag-version-prefix is 'v' which means the result of npm version patch would be v1.2.3 matching the behavior in npm 6.

the enhancement here is that if someone were to npm version patch --tag-version-prefix=release/ we would now output release/1.2.3 matching the tag we create.

References

Closes #2653

@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 18, 2021
@nlf nlf changed the base branch from latest to release/v7.5.5 February 18, 2021 20:53
@nlf nlf force-pushed the nlf/restore-tag-prefix-on-version branch from b4dcaa0 to 00afa31 Compare February 18, 2021 20:53
@nlf nlf merged commit 00afa31 into release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
@nlf nlf deleted the nlf/restore-tag-prefix-on-version branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] $(npm version patch) no longer returns vX.Y.Z, but only X.Y.Z
3 participants