Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor pack tests #4018

Merged
merged 1 commit into from Nov 9, 2021
Merged

chore: refactor pack tests #4018

merged 1 commit into from Nov 9, 2021

Conversation

wraithgar
Copy link
Member

Uses the real npm object and doesn't mock anything.

@wraithgar wraithgar requested a review from a team as a code owner November 8, 2021 18:43
@wraithgar wraithgar force-pushed the gar/pack-tests branch 2 times, most recently from d39a7a9 to a26f02b Compare November 8, 2021 18:51
@wraithgar wraithgar added the Release 8.x work is associated with a specific npm 8 release label Nov 8, 2021
Copy link
Member

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another FakeMockNpm bites the dust :shipit:

Uses the real npm object and doesn't mock anything.

PR-URL: #4018
Credit: @wraithgar
Close: #4018
Reviewed-by: @lukekarrys
@wraithgar wraithgar merged commit b8d6089 into release-next Nov 9, 2021
@wraithgar wraithgar deleted the gar/pack-tests branch November 9, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants