Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor changelog script to not require annotated commits #4214

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 6, 2022

instead of relying on commits annotated by @npmcli/pull we now use the git history to get the hashes, then use those hashes to populate a graphql query to fetch everything else

@nlf nlf requested a review from a team as a code owner January 6, 2022 18:57
@nlf nlf force-pushed the nlf/changelog-script-refactor branch from 2041648 to c1f7b91 Compare January 6, 2022 19:08
@npm-robot
Copy link
Contributor

npm-robot commented Jan 6, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 57.731 ±1.76 29.165 ±0.07 31.646 ±20.89 19.187 ±0.89 2.673 ±0.03 2.715 ±0.09 2.205 ±0.00 11.098 ±0.28 2.208 ±0.03 2.931 ±0.10
#4214 0.410 ±0.02 0.424 ±0.04 0.383 ±0.00 0.420 ±0.01 0.392 ±0.01 0.352 ±0.00 0.382 ±0.04 0.357 ±0.00 0.397 ±0.01 0.392 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.129 ±0.58 22.644 ±0.12 12.814 ±0.03 13.212 ±0.25 2.565 ±0.07 2.535 ±0.12 2.255 ±0.07 7.938 ±0.23 2.120 ±0.03 2.878 ±0.03
#4214 0.425 ±0.02 0.397 ±0.00 0.396 ±0.01 0.368 ±0.03 0.411 ±0.02 0.413 ±0.02 0.384 ±0.00 0.378 ±0.01 0.409 ±0.03 0.410 ±0.02

@nlf nlf merged commit c942f3a into release-next Jan 6, 2022
@nlf nlf deleted the nlf/changelog-script-refactor branch January 6, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants