-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tracker "idealTree:inflate:" already exists #4298
Conversation
It turns out that `new Arborist().buildIdealTree().meta.toString()` does not take into account the indentation in the package.json (tabs, in my case) the way `npm install --package-lock-only` does. This fixes that. Also included a bonus commit that removes redundant Promise stuff inside an `async function`.
@kirtangajjar I've recreated this PR because the arborist repo is being archived. Arborist is now maintained as a workspace within the CLI. Your commit authorship is still yours. |
found 20 benchmarks with statistically significant performance improvements
timing results
|
@fritzy Thanks for the heads up! I just have a question - why does my old pr diff and new pr diff look different? I see another commit in this PR too. Is this expected? |
203ab49
to
510f0ec
Compare
I'm going to close this and reopen a new PR with only the relevant commit @kirtangajjar |
MIGRATED FROM ARBORIST
Originally from npm/arborist#364
Originally by @kirtangajjar
Fixes https://github.com/npm/arborist/issues/330 as per solution described in comments.
References