Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tracker "idealTree:inflate:" already exists #4298

Closed
wants to merge 1 commit into from
Closed

Fix Tracker "idealTree:inflate:" already exists #4298

wants to merge 1 commit into from

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Jan 20, 2022 •
edited

MIGRATED FROM ARBORIST

Originally from npm/arborist#364
Originally by @kirtangajjar

Fixes https://github.com/npm/arborist/issues/330 as per solution described in comments.

References

@ljharb
fix(arborist): ensure indentation is preserved (#4218)
510f0ec 
It turns out that `new Arborist().buildIdealTree().meta.toString()` does
not take into account the indentation in the package.json (tabs, in my
case) the way `npm install --package-lock-only` does.

This fixes that. Also included a bonus commit that removes redundant
Promise stuff inside an `async function`.
@fritzy fritzy requested a review from a team as a code owner January 20, 2022 11:06
@fritzy
Copy link
Contributor Author

fritzy commented Jan 20, 2022

@kirtangajjar I've recreated this PR because the arborist repo is being archived. Arborist is now maintained as a workspace within the CLI. Your commit authorship is still yours.

@fritzy fritzy mentioned this pull request Jan 20, 2022
Closed
@npm-robot
Copy link
Contributor

npm-robot commented Jan 20, 2022 •
edited

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.335 ±2.20 36.978 ±0.10 23.388 ±0.60 26.371 ±1.29 3.799 ±0.06 3.810 ±0.09 3.050 ±0.01 15.617 ±0.17 3.031 ±0.01 4.322 ±0.02
#4298 0.506 ±0.01 0.520 ±0.00 0.510 ±0.01 0.539 ±0.01 0.495 ±0.00 0.502 ±0.01 0.549 ±0.03 0.524 ±0.01 0.500 ±0.00 0.500 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.529 ±0.44 28.995 ±0.37 16.976 ±0.16 18.010 ±0.01 3.445 ±0.06 3.479 ±0.02 3.115 ±0.09 11.698 ±0.07 2.860 ±0.03 3.866 ±0.02
#4298 0.511 ±0.02 0.538 ±0.01 0.513 ±0.00 0.534 ±0.01 0.514 ±0.01 0.514 ±0.01 0.531 ±0.02 0.506 ±0.01 0.543 ±0.01 0.533 ±0.02

@kirtangajjar
Copy link
Contributor

@fritzy Thanks for the heads up! I just have a question - why does my old pr diff and new pr diff look different?

I see another commit in this PR too. Is this expected?

@lukekarrys
Copy link
Contributor

I'm going to close this and reopen a new PR with only the relevant commit @kirtangajjar

@lukekarrys lukekarrys closed this Jan 20, 2022
@lukekarrys lukekarrys mentioned this pull request Jan 20, 2022
Merged
lukekarrys pushed a commit that referenced this pull request Feb 22, 2022
@kirtangajjar @lukekarrys
fix(arborist): use full location as tracker key when inflating
830b987 
Fixes: #4273
Ref: #4298
lukekarrys added a commit that referenced this pull request Feb 22, 2022
@lukekarrys @kirtangajjar
fix(arborist): use full location as tracker key when inflating (#4300)
9bdd1ac 
Fixes: #4273
Ref: #4298

Co-authored-by: Kirtan Gajjar <8456197+kirtangajjar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fritzy @npm-robot @kirtangajjar @lukekarrys @ljharb