fix(arborist): load actual tree on named updates #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arborist was not loading the actual tree when using named updates for global updates, that would result in removing all previously installed deps from a global install anytime the user would try to run `npm update <pkgname>`. This changeset fixes the problem by allowing the load of the actual tree if the `global` and `update.names` options are defined. Added a few more tests to illustrate but some of the snapshots already included were actually demonstrating the problem by having empty trees as result, these are now also updated with the expected tree result. Fixes: npm#3175
wraithgar
approved these changes
Jan 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arborist was not loading the actual tree when using named updates for
global updates, that would result in removing all previously installed
deps from a global install anytime the user would try to run
npm update <pkgname>.This changeset fixes the problem by allowing the load of the actual tree
if the
globalandupdate.namesoptions are defined.Added a few more tests to illustrate but some of the snapshots already
included were actually demonstrating the problem by having empty trees
as result, these are now also updated with the expected tree result.
References
Fixes: #3175