Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(arborist): save bundleDependencies to package.json when reifying #4387

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix(arborist): save bundleDependencies to package.json when reifying #4387

merged 1 commit into from
Feb 8, 2022

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner February 8, 2022 19:14
@wraithgar
Copy link
Member Author

Closes #3174

wraithgar
wraithgar commented Feb 8, 2022
View reviewed changes
lib/utils/config/definitions.js Outdated
@@ -1587,7 +1587,7 @@ define('save', {
default: true,
defaultDescription: `\`true\` unless when using \`npm update\` or
\`npm dedupe\` where it defaults to \`false\``,
usage: '-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reverting this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be a separate docs PR

nlf
nlf approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 lgtm

ruyadorno
ruyadorno approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@wraithgar wraithgar merged commit e631faf into release-next Feb 8, 2022
@wraithgar wraithgar deleted the gar/save-bundle branch February 8, 2022 19:23
@wraithgar wraithgar mentioned this pull request Feb 8, 2022
Closed
@npm-robot
Copy link
Contributor

npm-robot commented Feb 8, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.909 ±0.54 33.521 ±0.05 25.581 ±7.48 22.773 ±0.59 3.308 ±0.05 3.412 ±0.10 2.760 ±0.06 13.359 ±0.10 2.643 ±0.01 3.690 ±0.00
#4387 0.485 ±0.00 0.486 ±0.02 0.501 ±0.01 0.470 ±0.01 0.469 ±0.00 0.477 ±0.01 0.478 ±0.01 0.466 ±0.00 0.481 ±0.00 0.484 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.039 ±0.93 26.048 ±0.16 14.866 ±0.01 15.733 ±0.05 3.130 ±0.09 2.975 ±0.04 2.648 ±0.02 9.677 ±0.23 2.612 ±0.03 3.409 ±0.06
#4387 0.482 ±0.00 0.471 ±0.01 0.515 ±0.04 0.477 ±0.01 0.491 ±0.01 0.474 ±0.01 0.476 ±0.02 0.465 ±0.00 0.492 ±0.02 0.473 ±0.01

@nlf nlf mentioned this pull request Feb 10, 2022
Merged
@npm-robot npm-robot mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wraithgar @npm-robot @ruyadorno @nlf