Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm ls now respects --include-workspace-root #4481

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Feb 28, 2022

npm ls with a workspace specified used to ignore --include-workspace-root, but now includes the root when set.

Closes #3945

@fritzy fritzy requested a review from a team as a code owner February 28, 2022 08:20
@npm-robot
Copy link
Contributor

npm-robot commented Feb 28, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 57.114 ±2.58 27.877 ±0.24 29.717 ±18.42 18.696 ±0.88 2.777 ±0.04 2.848 ±0.06 2.245 ±0.06 10.949 ±0.42 2.162 ±0.01 3.082 ±0.06
#4481 0.389 ±0.00 0.385 ±0.01 0.399 ±0.01 0.390 ±0.00 0.406 ±0.01 0.399 ±0.00 0.390 ±0.01 0.402 ±0.03 0.403 ±0.00 0.391 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.951 ±3.35 21.692 ±0.29 12.128 ±0.34 13.473 ±0.14 2.536 ±0.06 2.474 ±0.01 2.197 ±0.04 8.058 ±0.05 2.082 ±0.05 2.810 ±0.04
#4481 0.427 ±0.00 0.390 ±0.00 0.398 ±0.00 0.386 ±0.01 0.414 ±0.01 0.425 ±0.01 0.395 ±0.01 0.388 ±0.01 0.389 ±0.00 0.396 ±0.03

@wraithgar wraithgar changed the base branch from latest to release-next March 1, 2022 15:47
@wraithgar wraithgar merged commit a0900bd into release-next Mar 2, 2022
@wraithgar wraithgar deleted the fritzy/ls-include-root branch March 2, 2022 17:51
This was referenced Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm ls does not include root
4 participants