Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly show npm view ./directory #4576

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: properly show npm view ./directory #4576

merged 1 commit into from
Mar 17, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 16, 2022

Closes #3790

@wraithgar wraithgar requested a review from a team as a code owner March 16, 2022 21:59
@npm-robot
Copy link
Contributor

found 1 benchmarks with statistically significant performance improvements

  • app-medium: no-modules

found 1 benchmarks with statistically significant performance regressions

  • app-large: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 47.812 ±0.13 28.743 ±0.13 16.467 ±0.02 19.087 ±0.31 2.738 ±0.01 2.781 ±0.02 2.277 ±0.05 10.602 ±0.11 2.221 ±0.06 3.231 ±0.11
#4576 54.274 ±3.64 27.923 ±0.46 31.636 ±21.50 18.900 ±2.16 2.669 ±0.03 2.808 ±0.02 2.291 ±0.04 11.101 ±0.49 2.248 ±0.02 3.401 ±0.42
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.179 ±0.34 21.930 ±0.09 12.108 ±0.16 13.325 ±0.03 2.508 ±0.02 2.520 ±0.01 2.263 ±0.04 9.057 ±0.70 2.140 ±0.03 3.838 ±1.44
#4576 36.513 ±0.92 21.973 ±0.32 12.453 ±0.38 13.401 ±0.21 2.393 ±0.17 2.535 ±0.01 2.318 ±0.06 8.126 ±0.15 2.082 ±0.01 2.904 ±0.03

@nlf nlf merged commit 84d1921 into latest Mar 17, 2022
@nlf nlf deleted the gar/npm-view-directory branch March 17, 2022 18:13
@nlf nlf mentioned this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm view ${tag} version got stuck when ran from workspace directory
3 participants