Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add foreground-scripts and ignore-scripts to commands #4580

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 17, 2022

I think this gets them all

Closes #3820

@wraithgar wraithgar requested a review from a team as a code owner March 17, 2022 15:36
@wraithgar wraithgar force-pushed the gar/install-h-foreground-scripts branch from 4d03a9e to 18b8322 Compare March 17, 2022 15:53
@nlf
Copy link
Contributor

nlf commented Mar 17, 2022

do we need to rebuild the docs as part of this pull request?

@wraithgar
Copy link
Member Author

That should have happened automatically. Something is broken.

@wraithgar wraithgar force-pushed the gar/install-h-foreground-scripts branch from 18b8322 to 232b956 Compare March 17, 2022 17:27
@nlf nlf merged commit a304052 into latest Mar 17, 2022
@nlf nlf deleted the gar/install-h-foreground-scripts branch March 17, 2022 18:03
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 56.720 ±5.42 33.502 ±0.14 31.942 ±17.10 21.369 ±0.99 3.218 ±0.06 3.154 ±0.02 2.643 ±0.12 12.270 ±0.08 2.624 ±0.06 3.764 ±0.05
#4580 53.102 ±2.38 32.994 ±0.16 32.317 ±18.28 22.278 ±0.79 3.219 ±0.01 3.247 ±0.01 2.647 ±0.00 12.425 ±0.13 2.646 ±0.05 3.857 ±0.17
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 40.291 ±1.28 25.584 ±0.30 13.764 ±0.06 15.250 ±0.10 2.934 ±0.06 2.961 ±0.04 2.634 ±0.01 9.120 ±0.01 2.459 ±0.04 3.408 ±0.03
#4580 40.383 ±1.33 25.385 ±0.03 14.220 ±0.07 15.198 ±0.01 2.981 ±0.09 3.057 ±0.02 2.651 ±0.03 9.288 ±0.08 2.525 ±0.04 3.456 ±0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] option foreground-scripts is not documented in npm install documentation
3 participants