Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): do not install invalid package name #4679

Merged

Conversation

ruyadorno
Copy link
Contributor

Throws an usage error if finding an invalid argument in global install.

References

Fixes: #3029

@ruyadorno ruyadorno added semver:patch semver patch level for changes Release 8.x work is associated with a specific npm 8 release labels Apr 4, 2022
@ruyadorno ruyadorno requested a review from a team as a code owner April 4, 2022 22:41
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests fail linting.

@ruyadorno ruyadorno force-pushed the fix-global-install-invalid-package-name branch from 571c324 to 6d6cec1 Compare April 19, 2022 18:08
Throws an usage error if finding an invalid argument in global install.

Fixes: npm#3029
@ruyadorno ruyadorno force-pushed the fix-global-install-invalid-package-name branch from 6d6cec1 to 5078999 Compare April 19, 2022 18:17
@ruyadorno ruyadorno added the release: next These items should be addressed in the next release label Apr 19, 2022
@lukekarrys lukekarrys merged commit b06e89f into npm:latest Apr 19, 2022
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm install "" installs package "undefined"
3 participants