Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate registryConfig application logic #4775

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

wraithgar
Copy link
Member

It should happen whenever we read a manifest anyways.

Tests were also rewritten to be real.

It should happen whenever we read a manifest anyways.

Tests were also rewritten to be real.
@wraithgar wraithgar requested a review from a team as a code owner April 19, 2022 18:29
@npm-robot
Copy link
Contributor

found 1 benchmarks with statistically significant performance regressions

  • app-large: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.873 ±0.67 27.629 ±0.68 16.032 ±0.07 18.151 ±0.58 2.750 ±0.02 2.762 ±0.02 2.211 ±0.02 10.505 ±0.02 2.204 ±0.01 3.234 ±0.04
#4775 55.642 ±0.55 27.421 ±0.12 25.838 ±13.77 18.341 ±0.37 2.810 ±0.00 2.784 ±0.01 2.213 ±0.01 10.541 ±0.04 2.255 ±0.03 3.290 ±0.14
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 34.219 ±0.93 21.288 ±0.07 11.975 ±0.07 12.737 ±0.13 2.551 ±0.01 2.501 ±0.00 2.226 ±0.00 7.894 ±0.05 2.089 ±0.02 2.894 ±0.10
#4775 36.757 ±0.47 21.450 ±0.00 12.063 ±0.11 12.912 ±0.14 2.528 ±0.02 2.529 ±0.00 2.252 ±0.01 7.867 ±0.05 2.108 ±0.00 2.854 ±0.01

@lukekarrys lukekarrys merged commit ced0acf into latest Apr 19, 2022
@lukekarrys lukekarrys deleted the gar/publish-tests branch April 19, 2022 23:25
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants