Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scripts/resetdeps.sh checks for cmark-gfm bindings #5690

Merged
merged 1 commit into from Oct 12, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/resetdeps.sh
Expand Up @@ -9,3 +9,9 @@ git checkout node_modules
node . i --ignore-scripts --no-audit --no-fund "$@"
node . rebuild --ignore-scripts
node . run dependencies --ignore-scripts
# check for cmark-gfm bindings
cmarkbinding=$(find `npm ls cmark-gfm --parseable \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this might need to use node . like the rest of the commands to ensure it uses the local repo and not the globally installed version while in CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nuts, I didn't catch that

| head -n 1` -name binding.node)
if [[ ! $cmarkbinding ]]; then
node . rebuild cmark-gfm
fi