Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make usage and completion static functions #6477

Merged
merged 1 commit into from May 22, 2023
Merged

Conversation

lukekarrys
Copy link
Member

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner May 19, 2023 17:41
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 19, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 37.717 ±1.76 15.031 ±0.07 15.140 ±0.05 17.448 ±1.34 2.624 ±0.25 2.438 ±0.02 2.047 ±0.01 10.211 ±0.12 2.043 ±0.01 3.181 ±0.02 0.367 ±0.00 0.383 ±0.00
#6477 39.464 ±0.34 15.818 ±0.36 15.500 ±0.22 18.379 ±1.34 2.575 ±0.01 2.530 ±0.01 2.081 ±0.02 10.616 ±0.03 2.070 ±0.00 3.136 ±0.05 0.353 ±0.00 0.402 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 25.683 ±1.18 11.585 ±0.04 11.178 ±0.05 12.278 ±0.52 2.197 ±0.03 2.224 ±0.03 2.042 ±0.02 7.524 ±0.13 1.911 ±0.01 2.734 ±0.01 0.344 ±0.00 0.373 ±0.01
#6477 27.059 ±4.23 12.097 ±0.07 11.833 ±0.12 12.744 ±0.16 2.321 ±0.04 2.279 ±0.00 2.110 ±0.01 7.930 ±0.09 2.005 ±0.01 2.742 ±0.02 0.361 ±0.00 0.404 ±0.01

@lukekarrys lukekarrys force-pushed the lk/static-usage branch 6 times, most recently from 2a2faf8 to 3df605a Compare May 21, 2023 22:35
@lukekarrys lukekarrys merged commit 4b5ccfc into latest May 22, 2023
44 checks passed
@lukekarrys lukekarrys deleted the lk/static-usage branch May 22, 2023 16:19
@github-actions github-actions bot mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants