Windows Development Fixes #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this make PRs from windows systems revert all these |
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
22 times, most recently
from
37e0683
to
35f307d
Compare
Merged
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
from
35f307d
to
1be9c1d
Compare
No since the files are normalized in git's index with LF line endings when committed but converted to CRLF on checkout when necessary. |
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
from
1be9c1d
to
8e6ca73
Compare
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
from
8e6ca73
to
74f3a9d
Compare
lukekarrys
changed the title
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
from
74f3a9d
to
be47d43
Compare
This makes it possible to do a fresh clone of this repo in Windows, and be able to run the resetdeps command successfully and then have a clean git status. We now check for a clean git status in during CI in Windows which was previously excluded. The changes required were to: - Delete our workspace symlinks from node_modules and add a step to resetdeps that will do a platform dependent symlink before the initial reification - Add line ending normalization to our `.gitattributes` file and commit the result. Git will store text with LF line endings automatically, except for some files like `cmd` scripts that need to be `crlf` and shell scripts that need to be `lf`. - Update workflows to call `node scripts/resetdeps.js` directly since a fresh clone of the repo wont have any symlinks in place, so any `node .` command will fail due to missing workspaces. Ref: npm/statusboard#562
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
14 times, most recently
from
ea9e4a0
to
28f11aa
Compare
lukekarrys
force-pushed
the
lk/workspace-symlinks
branch
from
28f11aa
to
6162f9f
Compare
|
In getting this tested I found that our bash scripts don't work under WSL v1, only WSL v2. I have WSL 2 installed locally and confirmed that the tests pass. GitHub Actions does not currently support WSL 2, so in that environment the test asserts that a new, more helpful error message is provided. |
This was referenced Jun 24, 2023
wraithgar
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two separate commits in this PR:
Windows Line Endings
This makes it possible to do a fresh clone of this repo in Windows, and be able to run the resetdeps command successfully and then have a clean git status. We now check for a clean git status in during CI in Windows which was previously excluded.
The changes required were to:
.gitattributesfile and commit the result. Git will store text with LF line endings automatically, except for some files likecmdscripts that need to becrlfand shell scripts that need to belf.node scripts/resetdeps.jsdirectly since a fresh clone of the repo wont have any symlinks in place, so anynode .command will fail due to missing workspaces.Windows Shim Tests
The second commit refactors the shim tests to ensure the
cmdscripts and all shells are tested in CI. It adds a new CI job that uses 3rd party actions to install WSL and Cygwin so that those can be tested.These new tests would fail without the previous commit since the wrong line endings would cause the scripts to error.
Ref: npm/statusboard#562