fix(view): filter out invalid semver #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 2, 2024
There was a problem hiding this comment.
nice, this problem (old versions with invalid semver) caused NullVoxPopuli/package-majors#15 - if you want another data point for tests
lukekarrys
approved these changes
Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-semverhas tightened its validation on what is an acceptibleversion since some old packages were published to the registry. They
can no longer exceed the maximum safe integer value. Packages with
invalid semver that were published before this validation cause npm to
crash when viewing info on the package as a whole. This filters out
those invalid semver versions.