fix: Arborist code cleanup #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/arborist-tweaks
branch
from
6ad1892
to
f69c20d
Compare
wraithgar
commented
Feb 23, 2024
|
Removing or severely limiting the number of options we can pass to methods will drastically improve the code complexity here but that's a semver major. |
wraithgar
force-pushed
the
gar/arborist-tweaks
branch
from
f69c20d
to
dd47038
Compare
lukekarrys
approved these changes
Feb 28, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of tiny tweaks to Arborist, in service of eventually cleaning it
up and removing the mixin approach.
Most of the fixes are like before: removing symbols in favor of private
attributes so we can easily find where state is being shared. There is
also some shuffling of single-use methods into larger classes.