Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer fs/promises over promisify #7399

Merged
merged 1 commit into from Apr 24, 2024
Merged

Conversation

lukekarrys
Copy link
Member

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner April 22, 2024 05:33
@wraithgar
Copy link
Member

This is likely to collide w/ my "remove tables" PR, I'll push it up tomorrow and would like to land that first.

lib/commands/doctor.js Outdated Show resolved Hide resolved
@lukekarrys lukekarrys force-pushed the lk/more-fs-promises branch 3 times, most recently from d8624ed to 67b9431 Compare April 22, 2024 21:06
@wraithgar
Copy link
Member

Arborist had more than needed individual comments but it seems we aren't consistently using fs or fs/promises to require the sync methods. This is a nitpick for sure but let's just do the same thing everywhere in the off chance we require more methods later.

Also should it be node:fs/promises?

@lukekarrys
Copy link
Member Author

The sync methods are not available from fs/promises so if we use them from the fs returned from fs/promises it should error somewhere.

@wraithgar
Copy link
Member

After reviewing again I was wrong, I remembered the sync part but it's also requring from fs

@wraithgar wraithgar merged commit 78447d7 into latest Apr 24, 2024
166 of 167 checks passed
@wraithgar wraithgar deleted the lk/more-fs-promises branch April 24, 2024 16:26
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants