Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert DepsQueue to re-sort on pop() #7499

Merged
merged 1 commit into from
May 10, 2024
Merged

fix: revert DepsQueue to re-sort on pop() #7499

merged 1 commit into from
May 10, 2024

Conversation

lukekarrys
Copy link
Contributor

A partial revert of #7124 and d3f1845.

Fixes #7491

@lukekarrys
Copy link
Contributor Author

lukekarrys commented May 9, 2024

Trying to come up with a test for this in build-ideal-tree but am having trouble taking the full package-lock.json from #7491 and reducing it to only the deps required to hit the infinite loop. The other option is a smoke-test, but I'd rather not make a full smoke-test for this.

Once I do have a test, I might take another shot at reverting the code to how it was previously, which was optimized to not re-sort the depsQueue on each pop.

@lukekarrys lukekarrys marked this pull request as ready for review May 10, 2024 01:26
@lukekarrys lukekarrys requested a review from a team as a code owner May 10, 2024 01:26
@lukekarrys lukekarrys merged commit e290352 into latest May 10, 2024
23 checks passed
@lukekarrys lukekarrys deleted the lk/7491-fix branch May 10, 2024 04:31
@github-actions github-actions bot mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm update hangs for some dependencies for npm>=10.4.0
2 participants