Treat env value of '' as a missing value

Fix: #2
npm · Aug 27, 2020 · 3b63000 · 3b63000
1 parent 217daf8
commit 3b63000
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -300,7 +300,7 @@ class Config {
     const prefix = 'npm_config_'
     const conf = Object.create(null)
     for (const [envKey, envVal] of Object.entries(this.env)) {
-      if (!/^npm_config_/i.test(envKey))
+      if (!/^npm_config_/i.test(envKey) || envVal === '')
         continue
       const key = envKey.substr('npm_config_'.length)
         .replace(/(?!^)_/g, '-') // don't replace _ at the start of the key

diff --git a/test/index.js b/test/index.js
@@ -192,7 +192,8 @@ loglevel = yolo
 
   t.test('load configs from all files, cli, and env', async t => {
     const env = {
-      npm_config_foo: 'from-env'
+      npm_config_foo: 'from-env',
+      npm_config_global: '',
     }
     const config = new Config({
       npmPath: `${path}/npm`,
@@ -207,6 +208,9 @@ loglevel = yolo
     })
     await config.load()
 
+    t.equal(config.get('global', 'env'), undefined, 'empty env is missing')
+    t.equal(config.get('global'), false, 'empty env is missing')
+
     config.set('asdf', 'quux', 'global')
     await config.save('global')
     const gres = readFileSync(`${path}/global/etc/npmrc`, 'utf8')