Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

feat: proxy now rewrites package JSON as it is served #3

Merged
merged 4 commits into from Jul 7, 2016

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 7, 2016

our little rewrite proxy now uses @npm/npm-urls to update JSON to a new process.env.FRONT_DOOR_HOST, as it is served.

!req.path.match(/\.tgz$/) && // tarball URLs.
req.method === 'GET' // we should only rewrite GET requests!
) {
pipe = false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be easier to read/grok if this var was named rewrite and its value inverted.

@coveralls
Copy link

coveralls commented Jul 7, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling dabd5fb on feat-rewrite-json into a071e6c on master.

@bcoe bcoe merged commit 5870a75 into master Jul 7, 2016
@bcoe bcoe deleted the feat-rewrite-json branch July 7, 2016 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants