Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add eslint-plugin-github and fix lint errors #714

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner September 26, 2023 20:25
@lukekarrys lukekarrys temporarily deployed to github-pages September 26, 2023 20:51 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages September 27, 2023 03:59 — with GitHub Actions Inactive
@lukekarrys
Copy link
Contributor Author

@kendallgassner as we talked about in office hours, I changed this element back to a <div aria-hidden="true"> and removed the aria-label since it is only being used as an invisible scroll handler.

I was also able to add a <code></code> element around the actual code block.

Here is a link to the relevant portion of the diff: https://github.com/npm/documentation/pull/714/files#diff-a937b27cceec7399880913557eacdd40b952463cbbdd2a10ffed757124437a8eR57-R66 Does that look good to you?

lukekarrys and others added 4 commits September 27, 2023 15:23
Co-authored-by: Kendall Gassner <kendallgassner@github.com>
Co-authored-by: Kendall Gassner <kendallgassner@github.com>
@lukekarrys lukekarrys merged commit a15e45f into main Sep 27, 2023
11 checks passed
@lukekarrys lukekarrys deleted the lk/eslint-github branch September 27, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants