-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to @primer/react #767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8280a5
to
a603d54
Compare
6f5cf97
to
cf6071d
Compare
lukekarrys
commented
Oct 17, 2023
3120afd
to
cd5972f
Compare
cf399fa
to
0b7fd60
Compare
4a2aa98
to
801f931
Compare
0707937
to
ea685a4
Compare
ce00e5d
to
d87038e
Compare
e5dbab7
to
eb7a0bf
Compare
Also turn on linting for mdx files and fix errors
0c167b3
to
5220b7e
Compare
54c4213
to
81e6daf
Compare
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also merges the
theme/
directory into the root since there is not a reason to keep it separate now that it is all in one repo. This removes the file shadowing that is possible with Gatsby themes, as well as us needing to support passing options to the theme. This PR also attempt to remove any dead code found during this migration.Code Block Screenshot
Resize Screenshot
Closes #765
Closes #764
Closes #738
Closes #734
Closes #772
Closes #770
Closes #760