Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch remote repo encoding #27

Closed
wants to merge 1 commit into from
Closed

fix: patch remote repo encoding #27

wants to merge 1 commit into from

Conversation

darcyclarke
Copy link

@darcyclarke darcyclarke commented Apr 14, 2021 •
edited
Loading

  • synopsis: ensure remote repo urls are properly encoded

@darcyclarke darcyclarke requested a review from nlf April 14, 2021 03:40
@darcyclarke darcyclarke force-pushed the darcyclarke/patch-repo-parsing branch from e69a3e8 to 123ba9c Compare April 14, 2021 03:51
@darcyclarke darcyclarke force-pushed the darcyclarke/patch-repo-parsing branch from 123ba9c to 2db705c Compare April 14, 2021 03:56
@darcyclarke darcyclarke changed the title fix: patch remote repo URL parsing fix: patch remote repo URL encoding Apr 14, 2021
@darcyclarke darcyclarke changed the title fix: patch remote repo URL encoding fix: patch remote repo encoding Apr 14, 2021
@nlf
Copy link
Contributor

nlf commented Apr 14, 2021

the major pitfall with this approach is that scp style urls like git@github.com:npm/cli won't parse with new URL() but are completely valid for git and would dodge the escaping

@nlf nlf mentioned this pull request Apr 14, 2021
Merged
@lukekarrys lukekarrys deleted the darcyclarke/patch-repo-parsing branch February 16, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf Awaiting requested review from nlf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darcyclarke @nlf