Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(travis): fix failed test for Node 4 #45

Closed
wants to merge 1 commit into from
Closed

ci(travis): fix failed test for Node 4 #45

wants to merge 1 commit into from

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Mar 21, 2019 •
edited

See the failed build log.

By using --no-esm option of tap (see https://www.node-tap.org/cli/).

image

@ybiquitous ybiquitous mentioned this pull request Mar 21, 2019
Closed
@isaacs
Copy link
Contributor

isaacs commented Aug 4, 2019

Turns out we really don't need esm support in this module's tests. Turned off for all tests in b681019, and dropping the unsupported node v4 in cca4ddd. (It still works in v4, just not officially supported, and hasn't been for some time now.)

@isaacs isaacs closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @isaacs