Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not encodeURIComponent the domain #53

Closed
wants to merge 1 commit into from
Closed

fix: do not encodeURIComponent the domain #53

wants to merge 1 commit into from

Commits on Oct 1, 2019

  1. fix: do not encodeURIComponent the domain 

    I ran into a situation where I have to test how Pacote handles git
shorthands from hosted-git-info, but I didn't want to ping GitHub to run
my tests.

I set up a git daemon and http server on localhost easily enough, but it
was still necessary to make it a 'real' HostedGit for the purposes of
npm-package-arg, and the : with port number was getting URL encoded.

This shows an example of doing this hack/test workaround, and fixes the
encoding issue.

It would be interesting to perhaps support GitHub Enterprise or on-prem
GitLab by letting users specify a prefix and format for hosted git info
in their npm configs, and then clone the definition with a different
domain name.
    @isaacs
    isaacs committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    4f159ac View commit details
    Browse the repository at this point in the history