polyfill fs.readdir withFileTypes for node 10.0 - 10.9 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 4, 2021
.github/workflows/ci.yml
Outdated
| matrix: | ||
| node-version: [10.x, 12.x] | ||
| os: [macOS-latest, ubuntu-latest, windows-latest] | ||
| node-version: [10.x, 12.x, 14.x, 15.x] |
There was a problem hiding this comment.
Suggested change
| node-version: [10.x, 12.x, 14.x, 15.x] | |
| node-version: [10.0.x, 10.x, 12.0, 12.x, 14.0, 14.x, 15.0, 15.x] |
? that way you can prevent regressions
isaacs
force-pushed
the
isaacs/polyfill-fs-readdir-with-file-types
branch
3 times, most recently
from
13ceab4
to
e70139c
Compare
ljharb
approved these changes
Feb 5, 2021
isaacs
force-pushed
the
isaacs/polyfill-fs-readdir-with-file-types
branch
3 times, most recently
from
4037299
to
1653d37
Compare
ruyadorno
approved these changes
Feb 8, 2021
- update GH actions, remove travis - npm audit fix Fix: npm/cli#2623 PR-URL: #4 Credit: @isaacs Close: #4 Reviewed-by: @ljharb, @ruyadorno
ruyadorno
force-pushed
the
isaacs/polyfill-fs-readdir-with-file-types
branch
from
1653d37
to
5f90dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @ljharb