Include query string in cache key

PR-URL: #38 Credit: @jpb Close: #38 Reviewed-by: @isaacs
npm · Dec 8, 2020 · 1f606e7 · 1f606e7
1 parent 73cd6d0
commit 1f606e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cache.js b/cache.js
@@ -35,6 +35,7 @@ function cacheKey (req) {
       port: parsed.port,
       hostname: parsed.hostname,
       pathname: parsed.pathname,
+      search: parsed.search,
     })
   }`
 }

diff --git a/test/cache.js b/test/cache.js
@@ -218,7 +218,7 @@ test('put method', (t) => {
       data,
       cacheOpts
     ) {
-      const expectedCacheKey = `make-fetch-happen:request-cache:${HOST}/put-test`
+      const expectedCacheKey = `make-fetch-happen:request-cache:${HOST}/put-test?a=1`
       t.equal(
         cacheKey,
         expectedCacheKey,
@@ -229,7 +229,7 @@ test('put method', (t) => {
     MockCacache.prototype.put.stream = function putStream () {}
     const Cache = mockRequire({ cacache: new MockCacache() })
     const cache = new Cache(dir, {})
-    const req = new Request(`${HOST}/put-test`)
+    const req = new Request(`${HOST}/put-test?a=1`)
     const body = new Minipass()
     body.end(CONTENT)
     const resOpts = {